Skip to content

Webpack config: Prefer target over environment#8092

Merged
balloob merged 1 commit intodevfrom
webpack-use-target
Jan 5, 2021
Merged

Webpack config: Prefer target over environment#8092
balloob merged 1 commit intodevfrom
webpack-use-target

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Jan 5, 2021

Breaking change

Proposed change

Use webpack target option which is a bunch of presets instead of directly managing the environment option. This makes sure we keep up to date as new options are introduced.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@balloob balloob merged commit 607eb6d into dev Jan 5, 2021
@delete-merged-branch delete-merged-branch bot deleted the webpack-use-target branch January 5, 2021 15:03
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants