Skip to content

Slightly increase max attribute value width#8085

Merged
bramkragten merged 1 commit intohome-assistant:devfrom
spacegaier:attr-width
Jan 4, 2021
Merged

Slightly increase max attribute value width#8085
bramkragten merged 1 commit intohome-assistant:devfrom
spacegaier:attr-width

Conversation

@spacegaier
Copy link
Copy Markdown
Member

Breaking change

Proposed change

With PR #7337 I changed the max-width for the attribute value from 200px to 50%. The goal was and still is to use more space esp. if a dialog is in wide-mode. However I did not consider that with all the padding, my 50% amounted to less than the original 200px, resulting in some cases where now values get split into two lines, e.g. timestamps.

This PR now increases the percentage to 60% so that around 200px will get used for the value before breaking into the second line.

Before:
image

After:
image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit 2c2226d into home-assistant:dev Jan 4, 2021
@spacegaier spacegaier deleted the attr-width branch January 5, 2021 11:39
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants