Slightly increase max attribute value width#8085
Merged
bramkragten merged 1 commit intohome-assistant:devfrom Jan 4, 2021
Merged
Slightly increase max attribute value width#8085bramkragten merged 1 commit intohome-assistant:devfrom
bramkragten merged 1 commit intohome-assistant:devfrom
Conversation
bramkragten
approved these changes
Jan 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
With PR #7337 I changed the max-width for the attribute value from 200px to 50%. The goal was and still is to use more space esp. if a dialog is in wide-mode. However I did not consider that with all the padding, my 50% amounted to less than the original 200px, resulting in some cases where now values get split into two lines, e.g. timestamps.
This PR now increases the percentage to 60% so that around 200px will get used for the value before breaking into the second line.
Before:

After:

Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: