Ensure consistent number display for gauge#8080
Merged
bramkragten merged 1 commit intohome-assistant:devfrom Jan 4, 2021
Merged
Ensure consistent number display for gauge#8080bramkragten merged 1 commit intohome-assistant:devfrom
bramkragten merged 1 commit intohome-assistant:devfrom
Conversation
3 tasks
bramkragten
approved these changes
Jan 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Currently the entity state is converted to a
Numberwhich means that integers loose their decimal. That leads to inconsistent number formatting/rendering, since e.g. entity card or entity-row use the state directly as input for the global number formatting logic.With this PR the conversion to
Numberis kept only for the NaN checks, but the gauge itself gets the original state value.Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: