Switch header sizes for ZHA pairing status card#8078
Merged
bramkragten merged 1 commit intohome-assistant:devfrom Jan 4, 2021
Merged
Switch header sizes for ZHA pairing status card#8078bramkragten merged 1 commit intohome-assistant:devfrom
bramkragten merged 1 commit intohome-assistant:devfrom
Conversation
Since the top title shows the result of the previous step ("Interview
Complete", "Configuration Complete", etc), while the second title shows
the current step ("Configuring", "Initializing", etc), having the top
title bigger would draw attention to it. So a user could see
"Configuration Complete" and assume pairing is done.
This change makes the second title bigger than the top one, so that the
user focus on the step that is in progress.
dmulcahey
approved these changes
Jan 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Since the top title on the ZHA device pairing status card shows the result of the previous step ("Interview Complete", "Configuration Complete", etc), while the second title shows the current step ("Configuring", "Initializing", etc), having the top title bigger would draw attention to it. So a user could see "Configuration Complete" and assume pairing is done.
This change makes the second title bigger than the top one, so that the user focus on the step that is in progress.
Before:
(at this stage, the interview is complete, but the pairing is still configuring the device. A user could look at "Interview Complete" and think pairing has finished)
After:
Type of change
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: