Skip to content

Show actual error path/key in YAML card editor#8076

Merged
bramkragten merged 2 commits intohome-assistant:devfrom
spacegaier:joined-error-path
Jan 4, 2021
Merged

Show actual error path/key in YAML card editor#8076
bramkragten merged 2 commits intohome-assistant:devfrom
spacegaier:joined-error-path

Conversation

@spacegaier
Copy link
Copy Markdown
Member

Breaking change

Proposed change

The card editor currently shows the wrong / incomplete error path. This is quite confusing.

Before the PR it only stated "tap_action" as the error path which is of course wrong, since it's the "confirmation" that we do not (yet) support. After the PR it looks like this:
image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit 293b56c into home-assistant:dev Jan 4, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2021
@spacegaier spacegaier deleted the joined-error-path branch January 5, 2021 11:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants