Correctly handle "hours to show" for footer graph#8071
Merged
spacegaier merged 2 commits intohome-assistant:devfrom Jan 26, 2021
Merged
Correctly handle "hours to show" for footer graph#8071spacegaier merged 2 commits intohome-assistant:devfrom
spacegaier merged 2 commits intohome-assistant:devfrom
Conversation
Member
Author
|
@zsarnett Since you did the implementation for the cached history, could you have a look at my changes if those look good to you |
bramkragten
reviewed
Jan 4, 2021
bramkragten
reviewed
Jan 4, 2021
bramkragten
reviewed
Jan 4, 2021
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
Member
Author
|
@bramkragten I verified your proposals. They indeed work as the order of entries in |
Member
Author
|
@zsarnett Ping. It would really like to have that in the next beta 😄. The issue drives me nuts on my dashboard. |
bramkragten
approved these changes
Jan 25, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
This PR fixes two issues:
This PR now ensures that the last previous history entry that now lies outside the "hours to show" is retained so that the graph has a correct "entry value" = value on the left border of the graph.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: