Skip to content

Ensure YAML editor gets updated during action change / deletion #8024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bramkragten merged 4 commits into from
Jan 4, 2021
Merged

Ensure YAML editor gets updated during action change / deletion #8024

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bab2fb6
Ensure YAML editor gets updated during action change / deletion
spacegaier Dec 21, 2020
1ef315e
Prevent YAML editor caching
spacegaier Jan 4, 2021
1ae3b99
Revert "Prevent YAML editor caching"
spacegaier Jan 4, 2021
8eef516
Update src/panels/config/automation/action/ha-automation-action-row.ts
spacegaier Jan 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/panels/config/automation/action/ha-automation-action-row.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,14 @@ import {
LitElement,
property,
PropertyValues,
query,
} from "lit-element";
import { dynamicElement } from "../../../../common/dom/dynamic-element-directive";
import { fireEvent } from "../../../../common/dom/fire_event";
import "../../../../components/ha-button-menu";
import "../../../../components/ha-card";
import "../../../../components/ha-svg-icon";
import type { HaYamlEditor } from "../../../../components/ha-yaml-editor";
import type { Action } from "../../../../data/script";
import { showConfirmationDialog } from "../../../../dialogs/generic/show-dialog-box";
import { haStyle } from "../../../../resources/styles";
Expand Down Expand Up @@ -103,6 +105,8 @@ export default class HaAutomationActionRow extends LitElement {

@internalProperty() private _yamlMode = false;

@query("ha-yaml-editor", true) private _yamlEditor?: HaYamlEditor;
Comment thread
spacegaier marked this conversation as resolved.
Outdated
Comment thread
spacegaier marked this conversation as resolved.
Outdated

protected updated(changedProperties: PropertyValues) {
if (!changedProperties.has("action")) {
return;
Expand All @@ -111,6 +115,10 @@ export default class HaAutomationActionRow extends LitElement {
if (!this._uiModeAvailable && !this._yamlMode) {
this._yamlMode = true;
}

if (this._yamlMode && this._yamlEditor) {
this._yamlEditor.setValue(this.action);
}
}

protected render() {
Expand Down