Skip to content

Auto capitalize first letter of entity row name#7962

Merged
bramkragten merged 1 commit intohome-assistant:devfrom
spacegaier:issue-7948
Jan 27, 2021
Merged

Auto capitalize first letter of entity row name#7962
bramkragten merged 1 commit intohome-assistant:devfrom
spacegaier:issue-7948

Conversation

@spacegaier
Copy link
Copy Markdown
Member

Breaking change

Proposed change

Issue was inspired by the automatic removal done by HA of area names in auto-generated dashboards. However, I can understand if my proposed fix is too far fetching.

I solved it by enforcing in general that the first letter is capitalized, since I think that looks nice and makes sense. However, if a user by design wants a lower case letter, we would prevent that then. I can only really think of this use case, if they include a brand name in their entity text where the brand starts with a lowercase letter.

If however, we only capitalize the first letter in this auto-cut-off scenario, we still would have the "brand issue'", so I would rather we are consistent for all use cases.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit 093e23c into home-assistant:dev Jan 27, 2021
@bramkragten bramkragten mentioned this pull request Jan 27, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Device name in card is lowercase

3 participants