Auto capitalize first letter of entity row name#7962
Merged
bramkragten merged 1 commit intohome-assistant:devfrom Jan 27, 2021
Merged
Auto capitalize first letter of entity row name#7962bramkragten merged 1 commit intohome-assistant:devfrom
bramkragten merged 1 commit intohome-assistant:devfrom
Conversation
bramkragten
approved these changes
Jan 27, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Issue was inspired by the automatic removal done by HA of area names in auto-generated dashboards. However, I can understand if my proposed fix is too far fetching.
I solved it by enforcing in general that the first letter is capitalized, since I think that looks nice and makes sense. However, if a user by design wants a lower case letter, we would prevent that then. I can only really think of this use case, if they include a brand name in their entity text where the brand starts with a lowercase letter.
If however, we only capitalize the first letter in this auto-cut-off scenario, we still would have the "brand issue'", so I would rather we are consistent for all use cases.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: