Move light effects above color picker

[spacegaier]

Breaking change

Proposed change

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New feature (thank you!)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example configuration

Additional information

• This PR fixes or closes issue: fixes Light effects drop-down location #7379
• This PR is related to issue or discussion: 'Effect' drop-down on light cards doesn't fit properly #7736
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• There is no commented out code in this PR.
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

[bramkragten]

I don't think we should move a less-used feature up in the UI for these reasons

[spacegaier]

I don't think we should move a less-used feature up in the UI for these reasons

I do get your point. In the end it's matter of how we weigh the pro/cons for the move:

Pro:

• Better discoverability of the effects option (might be outside the screen on smaller devices)
• Better usability on smaller screens since now the effects dropdown has enough space to show more than only one or two rows before hitting the bottom screen border, see screenshot in linked discussion (the color palette doesn't care about its position in that regard)

Cons:

• Lesser used element (probably?) now further up (but at least does not hurt the discoverability of the color palette)

If a light does not have defined effects, then of course the dropdown will not be rendered at all.

[bramkragten]

Can we look into a different dropdown menu instead? Like mwc-select?

[spacegaier]

Can we look into a different dropdown menu instead? Like mwc-select?

For which goal? How does that impact the position of the dropdown in the dialog?

[bramkragten]

My understanding is that the problem is that the current dropdown always goes down, even if there is no room down and it should actually go up?

I think they solved that in mwc-select

[spacegaier]

That would solve part of the issue, but not the "detectability" / discovery in the UI overall.

[bramkragten]

We moved most controls below the color picker now, like white value, etc. It would be weird to move effects up now, as I still think it is way less used...