Update group reload string#7938
Merged
bramkragten merged 3 commits intohome-assistant:devfrom Dec 29, 2020
Merged
Conversation
spacegaier
reviewed
Dec 16, 2020
src/translations/en.json
Outdated
| "reload": "Reload {domain}", | ||
| "core": "Reload location & customizations", | ||
| "group": "Reload groups, group entities, and notify services", | ||
| "group": "Reload groups, group entities and notify services", |
Member
There was a problem hiding this comment.
Suggested change
| "group": "Reload groups, group entities and notify services", | |
| "group": "Reload groups, group entities, and group notify services", |
Wouldn't that make it even clearer?
Member
There was a problem hiding this comment.
Then I would propose we do the same for "rest" to be consistent.
Member
Author
There was a problem hiding this comment.
If I didn't miss any, there are three other strings that mention notify services.
On one hand telegram and smtp are probably fine:
frontend/src/translations/en.json
Lines 1077 to 1078 in a8d0134
rest on the other could be changed:
frontend/src/translations/en.json
Line 1065 in a8d0134
Although to be fair I don't think it's as bad as with group since it IMO clearly applies to rest.
Co-authored-by: Philip Allgaier <philip.allgaier@gmx.de>
spacegaier
approved these changes
Dec 16, 2020
bramkragten
approved these changes
Dec 29, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Update string for group reload service in server control. Especially if this entry is the only one mentioning
notify services, a user could assume that it would reload thenotifycomponent. See below. Removing the comma makes it clear that it's thegroup notify serviceswhich will be reloaded. It will also be more consistent with other reload strings, eg. for restfrontend/src/translations/en.json
Line 1065 in ffc19e5
Type of change
Example configuration
--
Additional information
--
Checklist
If user exposed functionality or configuration variables are added/changed: