Skip to content

Fix border radius for labeled slider#7929

Merged
bramkragten merged 1 commit intohome-assistant:devfrom
spacegaier:labeled-slider-radius
Dec 29, 2020
Merged

Fix border radius for labeled slider#7929
bramkragten merged 1 commit intohome-assistant:devfrom
spacegaier:labeled-slider-radius

Conversation

@spacegaier
Copy link
Copy Markdown
Member

Breaking change

Proposed change

So far the border-radius was applied to the whole ha-labeled-slider element, which meant that e.g. for the color temperature background only the lower right corner of the blue to orange background was affected. The radius for the other three corners had no effect.

With this PR the radius is now applied to the actual slider for a consistent look:

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit 95b5526 into home-assistant:dev Dec 29, 2020
@bramkragten bramkragten mentioned this pull request Dec 29, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2020
@spacegaier spacegaier deleted the labeled-slider-radius branch January 5, 2021 11:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants