Skip to content

Remove use of named groups in regexp#7921

Merged
bramkragten merged 1 commit intohome-assistant:devfrom
uvjustin:remove-named-capture-groups-ha-hls-player
Dec 7, 2020
Merged

Remove use of named groups in regexp#7921
bramkragten merged 1 commit intohome-assistant:devfrom
uvjustin:remove-named-capture-groups-ha-hls-player

Conversation

@uvjustin
Copy link
Copy Markdown
Contributor

@uvjustin uvjustin commented Dec 7, 2020

Proposed change

We previously used named capture groups in a regexp in ha-hls-player to be more clear about what the regexp is doing. Unfortunately named capture groups were not supported in firefox versions < 78. This PR reverts to using regular capture groups instead of named ones.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten added this to the 1.0.0 milestone Dec 7, 2020
@bramkragten bramkragten merged commit baf3830 into home-assistant:dev Dec 7, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clicks on entities do not work

3 participants