Skip to content

Add CSS Variables for Menu#7917

Merged
bramkragten merged 2 commits intohome-assistant:devfrom
myleskeeffe:dev
Jan 11, 2021
Merged

Add CSS Variables for Menu#7917
bramkragten merged 2 commits intohome-assistant:devfrom
myleskeeffe:dev

Conversation

@myleskeeffe
Copy link
Copy Markdown
Contributor

@myleskeeffe myleskeeffe commented Dec 6, 2020

Add CSS Variables for Menu - Fallback value is as default (primary-text-color and primary-background-color). This allows for the menu to have a color/background that is decoupled from the main pages color/background.

Proposed change

Creates CSS variables for the menu's background & text colour (the part which contains the hamburger menu icon). This allows for these to be specified separately, and not be the same as the main pages.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Code quality improvements to existing code or addition of tests
  • Breaking change (fix/feature causing existing functionality to break)

Example configuration

Additional information

For example:
From:
fix3
To:
fix2

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Add CSS Variables for Menu - Fallback value is as default (primary-text-color and primary-background-color). This allows for the menu to have a color/background that is decoupled from the main pages color/background.
@homeassistant
Copy link
Copy Markdown
Contributor

Hi @myleskeeffe,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

Update CSS Variables to better conform to already existing names.
@bramkragten bramkragten merged commit 56d88b4 into home-assistant:dev Jan 11, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants