Add network visualization to the ZHA config panel#7802
Merged
bramkragten merged 14 commits intohome-assistant:devfrom Nov 26, 2020
Merged
Add network visualization to the ZHA config panel#7802bramkragten merged 14 commits intohome-assistant:devfrom
bramkragten merged 14 commits intohome-assistant:devfrom
Conversation
balloob
reviewed
Nov 24, 2020
src/panels/config/integrations/integration-panels/zha/zha-config-dashboard.ts
Outdated
Show resolved
Hide resolved
balloob
reviewed
Nov 24, 2020
src/panels/config/integrations/integration-panels/zha/zha-network-visualization-page.ts
Outdated
Show resolved
Hide resolved
balloob
reviewed
Nov 24, 2020
src/panels/config/integrations/integration-panels/zha/zha-network-visualization-page.ts
Outdated
Show resolved
Hide resolved
balloob
reviewed
Nov 24, 2020
src/panels/config/integrations/integration-panels/zha/zha-network-visualization-page.ts
Outdated
Show resolved
Hide resolved
bramkragten
reviewed
Nov 25, 2020
src/panels/config/integrations/integration-panels/zha/zha-config-dashboard.ts
Outdated
Show resolved
Hide resolved
bramkragten
reviewed
Nov 25, 2020
bramkragten
reviewed
Nov 25, 2020
| if (this.hass) { | ||
| this._fetchData(); | ||
| } | ||
| this._network = new Network( |
Member
There was a problem hiding this comment.
You should make sure we are connected when creating this, as otherwise the height and width could not be set yet.
Member
There was a problem hiding this comment.
Or you should update it in onConnected when this._network is defined
bramkragten
reviewed
Nov 25, 2020
src/panels/config/integrations/integration-panels/zha/zha-network-visualization-page.ts
Outdated
Show resolved
Hide resolved
bramkragten
reviewed
Nov 25, 2020
src/panels/config/integrations/integration-panels/zha/zha-network-visualization-page.ts
Outdated
Show resolved
Hide resolved
bramkragten
reviewed
Nov 25, 2020
src/panels/config/integrations/integration-panels/zha/zha-network-visualization-page.ts
Outdated
Show resolved
Hide resolved
bramkragten
reviewed
Nov 25, 2020
src/panels/config/integrations/integration-panels/zha/zha-network-visualization-page.ts
Outdated
Show resolved
Hide resolved
…ig-dashboard.ts Co-authored-by: Bram Kragten <mail@bramkragten.nl>
…ork-visualization-page.ts Co-authored-by: Bram Kragten <mail@bramkragten.nl>
…ork-visualization-page.ts Co-authored-by: Bram Kragten <mail@bramkragten.nl>
dmulcahey
force-pushed
the
dm/zha-network-visualization
branch
from
c6948d4 to
ed0617e
Compare
bramkragten
approved these changes
Nov 26, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
This PR adds a network visualization to the ZHA configuration panel. We can replace this with ZigZag if that is desired when it is ready.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: