Skip to content

Clean up some types#7801

Merged
balloob merged 3 commits intodevfrom
clean-up-types
Nov 25, 2020
Merged

Clean up some types#7801
balloob merged 3 commits intodevfrom
clean-up-types

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Nov 24, 2020

Breaking change

Proposed change

Cleans up some types. Moves the entity types into the data folder.

Cleaned up according to performance tips from https://github.com/microsoft/TypeScript/wiki/Performance

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@balloob
Copy link
Copy Markdown
Member Author

balloob commented Nov 24, 2020

@zsarnett I agree it's nicer, but it's out of scope for this PR :)

balloob and others added 3 commits November 25, 2020 11:20
@balloob balloob merged commit fc48c59 into dev Nov 25, 2020
@balloob balloob deleted the clean-up-types branch November 25, 2020 11:31
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants