Skip to content

Use minified bundle of node vibrant#7784

Merged
bramkragten merged 4 commits intodevfrom
tweak-node-vibrant-pt2
Jan 26, 2021
Merged

Use minified bundle of node vibrant#7784
bramkragten merged 4 commits intodevfrom
tweak-node-vibrant-pt2

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Nov 23, 2020

Breaking change

Proposed change

I was cherry picking parts of Node Vibrant but realized that it doesn't matter, as default options pull in pretty much everything anyway.

So now switching it to the bundled version, which does not choke WDS.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit 4cd95b7 into dev Jan 26, 2021
@bramkragten bramkragten deleted the tweak-node-vibrant-pt2 branch January 26, 2021 22:24
@bramkragten bramkragten mentioned this pull request Jan 27, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants