Skip to content

Close webpack compiler on prod build#7779

Merged
bramkragten merged 2 commits intodevfrom
webpack-close-prod-builds
Nov 23, 2020
Merged

Close webpack compiler on prod build#7779
bramkragten merged 2 commits intodevfrom
webpack-close-prod-builds

Conversation

@balloob
Copy link
Member

@balloob balloob commented Nov 22, 2020

Breaking change

Proposed change

When doing prod builds, close the webpack compiler when done so it can store caches.

Per https://webpack.js.org/migrate/5/#cleanup-the-build-code

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@balloob balloob marked this pull request as ready for review November 22, 2020 21:49
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
@bramkragten bramkragten merged commit 39ff641 into dev Nov 23, 2020
@bramkragten bramkragten deleted the webpack-close-prod-builds branch November 23, 2020 11:48
@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants