Skip to content

Drop webpackChunkName#7778

Merged
bramkragten merged 2 commits intodevfrom
drop-webpack-chunkname
Nov 23, 2020
Merged

Drop webpackChunkName#7778
bramkragten merged 2 commits intodevfrom
drop-webpack-chunkname

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Nov 22, 2020

Breaking change

Proposed change

Webpack 5 will give useful names to chunks. We no longer should define them ourselves.

See https://webpack.js.org/migrate/5/#cleanup-the-code

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit 6d4569c into dev Nov 23, 2020
@bramkragten bramkragten deleted the drop-webpack-chunkname branch November 23, 2020 09:39
@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants