Skip to content

Clean up node-vibrant#7777

Merged
bramkragten merged 4 commits intodevfrom
cleanup-node-vibrant
Nov 23, 2020
Merged

Clean up node-vibrant#7777
bramkragten merged 4 commits intodevfrom
cleanup-node-vibrant

Conversation

@balloob
Copy link
Member

@balloob balloob commented Nov 22, 2020

Breaking change

Proposed change

Migrate to node-vibrant 3.2 alpha-1.

It is a major re-org of the code, which includes dropping a full lodash include.

Verified gallery that the output remains the same.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit e2fed24 into dev Nov 23, 2020
@bramkragten bramkragten deleted the cleanup-node-vibrant branch November 23, 2020 11:47
@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants