Skip to content

Ensure new grid card options don't break editor#7762

Merged
balloob merged 1 commit intohome-assistant:devfrom
spacegaier:grid-options-support
Nov 21, 2020
Merged

Ensure new grid card options don't break editor#7762
balloob merged 1 commit intohome-assistant:devfrom
spacegaier:grid-options-support

Conversation

@spacegaier
Copy link
Copy Markdown
Member

Breaking change

Proposed change

Ensure that specifying square or columns does not break the editor.

Note: This PR does not offer a way to specify those values in the editor themselves, since the grid/stack itself has no real editor element yet. That will need to be covered in a future PR.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@balloob balloob merged commit ba505b1 into home-assistant:dev Nov 21, 2020
@spacegaier spacegaier deleted the grid-options-support branch November 21, 2020 21:03
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2020
@zsarnett zsarnett modified the milestones: 0.118.4, 0.118.5 Nov 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants