Skip to content

Ensure more consistent lovelace config errors#7755

Merged
bramkragten merged 4 commits intohome-assistant:devfrom
spacegaier:consistent-card-errors
Nov 21, 2020
Merged

Ensure more consistent lovelace config errors#7755
bramkragten merged 4 commits intohome-assistant:devfrom
spacegaier:consistent-card-errors

Conversation

@spacegaier
Copy link
Copy Markdown
Member

Breaking change

Proposed change

  1. Added proper errors where entity is required, rather than not having an empty, but still space using card
  2. Check array length where multiple entities can be specified (a simple check for existance or is-array not sufficient since during initial editor creation all have an entity set, but user can remove it)
  3. Mark entity input fields as required (where previously incorrectly marked as optional)
  4. Consistent wording of errors

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit c53ec6e into home-assistant:dev Nov 21, 2020
@spacegaier spacegaier deleted the consistent-card-errors branch November 21, 2020 16:46
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants