Skip to content

Show error if no entity specified for history card#7752

Merged
bramkragten merged 1 commit intohome-assistant:devfrom
spacegaier:issue-7749
Nov 21, 2020
Merged

Show error if no entity specified for history card#7752
bramkragten merged 1 commit intohome-assistant:devfrom
spacegaier:issue-7749

Conversation

@spacegaier
Copy link
Member

Breaking change

Proposed change

Add check if no entities are specified for history graph card. Without the check the UI hangs as a huge card with all entities is retrieved and rendered.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit aad6492 into home-assistant:dev Nov 21, 2020
@spacegaier spacegaier deleted the issue-7749 branch November 21, 2020 16:48
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding a History Graph card hangs browser

4 participants