Skip to content

WIP initial Blueprint UI#7695

Merged
bramkragten merged 3 commits intodevfrom
blueprints
Nov 18, 2020
Merged

WIP initial Blueprint UI#7695
bramkragten merged 3 commits intodevfrom
blueprints

Conversation

@bramkragten
Copy link
Member

Todo

  • Localization
  • Not happy with create new automation dialog

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

attr-for-selected="data-blueprint-path"
@iron-select=${this._blueprintChanged}
>
<paper-item data-blueprint-path="">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still using Polymer 😬

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The paper-dropdown/paper-list you mean?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah.

: html``}
</div>
</div>
<mwc-button slot="primaryAction" @click=${this._blank}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One day we should also offer options like "Automate this area" or "Automate this device", to help getting options down.

label="Filename"
></paper-input>
<pre>${this._result.raw_data}</pre>`
: html`<paper-input
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need an example or a link to the docs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a to do for myself.

@bramkragten bramkragten marked this pull request as ready for review November 17, 2020 13:26
@bramkragten bramkragten merged commit 4973d8f into dev Nov 18, 2020
@bramkragten bramkragten deleted the blueprints branch November 18, 2020 11:20
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants