Skip to content

Use proper night time icon consistently for sun integration#7681

Merged
bramkragten merged 1 commit intohome-assistant:devfrom
spacegaier:sun-night-icon
Nov 17, 2020
Merged

Use proper night time icon consistently for sun integration#7681
bramkragten merged 1 commit intohome-assistant:devfrom
spacegaier:sun-night-icon

Conversation

@spacegaier
Copy link
Member

Breaking change

Proposed change

Ensure that for the "sun" integration the state badge, glances and more-info consistently show the same icon. It is now based upon the above_horizon and below_horizon state.

image

image

The icon I used for night is also used e.g. by the alarm integration for night arming.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes Sun showing Moon icon? #7672
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit 90f7dba into home-assistant:dev Nov 17, 2020
@spacegaier spacegaier deleted the sun-night-icon branch November 17, 2020 17:53
@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sun showing Moon icon?

3 participants