Skip to content

Quick Bar should only capitalize letters in Command Palette#7671

Merged
bramkragten merged 1 commit intodevfrom
quick-bar-fix-capitalizing-entities
Nov 16, 2020
Merged

Quick Bar should only capitalize letters in Command Palette#7671
bramkragten merged 1 commit intodevfrom
quick-bar-fix-capitalizing-entities

Conversation

@donkawechico
Copy link
Copy Markdown
Contributor

@donkawechico donkawechico commented Nov 12, 2020

Proposed change

Entity IDs (and friendly names) are currently being title-cased which isn't appropriate. We should only do sentence-casing for Command Palette items (to fix the issue of inconsistent string capitalizing rules in en.json)

Screenshot of Issue:
image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@donkawechico donkawechico added this to the 0.118.0 milestone Nov 12, 2020
@bramkragten bramkragten merged commit 3b7a189 into dev Nov 16, 2020
@bramkragten bramkragten deleted the quick-bar-fix-capitalizing-entities branch November 16, 2020 11:45
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants