Skip to content

Add a github option when copying from system health#7663

Merged
bramkragten merged 4 commits intodevfrom
copy-for-github
Nov 13, 2020
Merged

Add a github option when copying from system health#7663
bramkragten merged 4 commits intodevfrom
copy-for-github

Conversation

@ludeeus
Copy link
Member

@ludeeus ludeeus commented Nov 11, 2020

Breaking change

Proposed change

Followup to #7593 (comment)

Changes the copy icon to be a menu, with raw/github options.

raw example
github example

for github copy, all but the "homeassistant" section is wrapped in "details" tags to make the expandable to now drown issues.

Also changes the tooltip, to a toast.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Peek 2020-11-11 22-46

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

ludeeus and others added 2 commits November 12, 2020 16:56
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
@bramkragten bramkragten merged commit b9f8029 into dev Nov 13, 2020
@bramkragten bramkragten deleted the copy-for-github branch November 13, 2020 17:20
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants