add actions to weather-forecast-card#7659
Merged
bramkragten merged 2 commits intohome-assistant:devfrom Jan 27, 2021
Merged
Conversation
Contributor
|
Should we add Hold and Double-tap here? I think we need to rethink why those are useful. I think there is a potential case for having tap action but hold and double tap? The hold should just be more info all the time. But on the other side. Other cards have these features is it expect that all cards do? We should create a guideline for what cards should and should not have actions. |
Member
Author
|
@zsarnett I can understand your sentiment but I think it would be easier for us to just have all types on this particular card in terms of maintenance and experience. |
bramkragten
approved these changes
Dec 2, 2020
29e4e8c to
b97cde9
Compare
8 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Add actions to weather-forecast-card. I opted not to add this to the editor at least for now as I'm updating actions editor in another PR and not sure if this should be part of the "common" options or an advanced one? I really do like the idea of being able to navigate to an external site for a more detailed forecast though.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: