Skip to content

add actions to weather-forecast-card#7659

Merged
bramkragten merged 2 commits intohome-assistant:devfrom
iantrich:weather-actions
Jan 27, 2021
Merged

add actions to weather-forecast-card#7659
bramkragten merged 2 commits intohome-assistant:devfrom
iantrich:weather-actions

Conversation

@iantrich
Copy link
Copy Markdown
Member

@iantrich iantrich commented Nov 11, 2020

Breaking change

Proposed change

Add actions to weather-forecast-card. I opted not to add this to the editor at least for now as I'm updating actions editor in another PR and not sure if this should be part of the "common" options or an advanced one? I really do like the idea of being able to navigate to an external site for a more detailed forecast though.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

type: weather-forecast
entity: weather.home
tap_action:
  action: url
  url_path: https://www.buienradar.nl

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@zsarnett
Copy link
Copy Markdown
Contributor

Should we add Hold and Double-tap here? I think we need to rethink why those are useful. I think there is a potential case for having tap action but hold and double tap?

The hold should just be more info all the time.

But on the other side. Other cards have these features is it expect that all cards do?

We should create a guideline for what cards should and should not have actions.

@iantrich
Copy link
Copy Markdown
Member Author

@zsarnett I can understand your sentiment but I think it would be easier for us to just have all types on this particular card in terms of maintenance and experience.

@bramkragten bramkragten merged commit e69f360 into home-assistant:dev Jan 27, 2021
@bramkragten bramkragten mentioned this pull request Jan 27, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FR: Add tap/hold_action to the weather-forecast card

4 participants