Skip to content

Add missing 1px to prevent slider pin cutoff#7657

Merged
bramkragten merged 1 commit intohome-assistant:devfrom
spacegaier:slider-pin-cutoff-fix
Nov 16, 2020
Merged

Add missing 1px to prevent slider pin cutoff#7657
bramkragten merged 1 commit intohome-assistant:devfrom
spacegaier:slider-pin-cutoff-fix

Conversation

@spacegaier
Copy link
Member

@spacegaier spacegaier commented Nov 11, 2020

Breaking change

Proposed change

Follow-up to PR #7651. @ludeeus was right wrong and it needs to be 5px 😆.

Before:
image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@ludeeus
Copy link
Member

ludeeus commented Nov 11, 2020

That means I was wrong ;)

@spacegaier
Copy link
Member Author

That means I was wrong ;)

Ahm...yeah...typo 😉 . Fixed.

@ludeeus
Copy link
Member

ludeeus commented Nov 11, 2020

5 is so strange...
I'm more in favor of 6 in that case, @bramkragten ?

@bramkragten
Copy link
Member

I think 5 is fine in this case... Ideally, we should not have to do this at all...

@bramkragten bramkragten added this to the 0.118.0 milestone Nov 12, 2020
@bramkragten bramkragten merged commit 79c542b into home-assistant:dev Nov 16, 2020
@spacegaier spacegaier deleted the slider-pin-cutoff-fix branch November 16, 2020 11:59
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants