Reduce "wasted" screen space#7655
Merged
bramkragten merged 3 commits intohome-assistant:devfrom Nov 23, 2020
Merged
Conversation
spacegaier
changed the title
spacegaier
force-pushed
the
optimize-vert-space
branch
from
40ceba0 to
dee3839
Compare
bramkragten
reviewed
Nov 23, 2020
| .actions { | ||
| margin: 0 8px; | ||
| padding-top: 20px; | ||
| margin: 0; |
Member
There was a problem hiding this comment.
On smaller screens the actions are now touching the badge?
Member
Author
There was a problem hiding this comment.
Even on the smallest simulated screen, there is still space between them
bramkragten
approved these changes
Nov 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Removed some unneeded paddings that visually broke the alignment in the more-info dialogs.
Before:
After:
After (shrunk padding above the state buttons):
Moved the three-dot icon 4px up to properly align with the header.
Left old, right after:
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: