Skip to content

Check for integration before loading logo#7653

Merged
bramkragten merged 1 commit intodevfrom
check-for-integrations
Nov 11, 2020
Merged

Check for integration before loading logo#7653
bramkragten merged 1 commit intodevfrom
check-for-integrations

Conversation

@ludeeus
Copy link
Member

@ludeeus ludeeus commented Nov 11, 2020

Breaking change

Proposed change

We try to load the logo before we have an integration to load, which results in a 404

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit 0cc2d3a into dev Nov 11, 2020
@bramkragten bramkragten deleted the check-for-integrations branch November 11, 2020 14:16
@bramkragten bramkragten mentioned this pull request Nov 11, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants