Skip to content

Fix view height in edit mode #7646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bramkragten merged 1 commit into from
Nov 11, 2020
Merged

Fix view height in edit mode #7646

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 15 additions & 11 deletions src/panels/lovelace/hui-root.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,16 +102,13 @@ class HUIRoot extends LitElement {

protected render(): TemplateResult {
return html`
<ha-app-layout id="layout">
<app-header
slot="header"
effects="waterfall"
class=${classMap({
"edit-mode": this._editMode,
})}
fixed
condenses
>
<ha-app-layout
class=${classMap({
"edit-mode": this._editMode,
})}
id="layout"
>
<app-header slot="header" effects="waterfall" fixed condenses>
${this._editMode
? html`
<app-toolbar class="edit-mode">
Expand Down Expand Up @@ -819,7 +816,8 @@ class HUIRoot extends LitElement {
text-transform: uppercase;
}

.edit-mode {
.edit-mode app-header,
.edit-mode app-toolbar {
background-color: var(--dark-color, #455a64);
color: var(--text-dark-color);
}
Expand Down Expand Up @@ -864,6 +862,12 @@ class HUIRoot extends LitElement {
position: relative;
display: flex;
}
/**
* In edit mode we have the tab bar on a new line *
*/
.edit-mode #view {
min-height: calc(100vh - var(--header-height) - 48px);
}
#view > * {
/**
* The view could get larger than the window in Firefox
Expand Down