Skip to content

Add fix to more-info for media players without play/pause state#7608

Merged
bramkragten merged 3 commits intohome-assistant:devfrom
kg333:dev
Nov 10, 2020
Merged

Add fix to more-info for media players without play/pause state#7608
bramkragten merged 3 commits intohome-assistant:devfrom
kg333:dev

Conversation

@kg333
Copy link
Contributor

@kg333 kg333 commented Nov 6, 2020

Proposed change

This corrects issue #7074 introduced in 0.115, and allows media players that do not show playing or paused states to still have a play/pause button if supported.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

N/A

Additional information

I do not have a media player that does support playing/pause states available in my dev environment. If someone could please test this fix with a Google Home or similar device to ensure functionality does not change for these devices, it'd be greatly appreciated.

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • N/A [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@homeassistant
Copy link
Contributor

Hi @kg333,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

kg333 and others added 2 commits November 10, 2020 09:55
@bramkragten bramkragten merged commit 2e289cd into home-assistant:dev Nov 10, 2020
@bramkragten bramkragten mentioned this pull request Nov 11, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Media player not showing play or pause

3 participants