Add clipboard button#7607
Conversation
|
Can you please post a screenshot. |
|
Okay... Let me get my dev instance running. |
|
|
KTibow
force-pushed
the
patch-9
branch
2 times, most recently
from
2f0643d to
cadb6c8
Compare
Yeah, I think currently the new button is not justified between the more-info button and the hyperlink. Needs to move slightly to the left I think. |
|
@spacegaier What would be a good way to do that? I know using |
Not sure what the best way is (not a CSS guru myself). Perhaps putting all three elements into a flex box might work and sort that out. The more manual approach would be so set a CSS class for the second icon that removes the left margin if that is causing the too wide gap to the first icon. |
|
Make sure there is enough space between the buttons so you can touch it on mobile. Check the guidelines: https://material.io/develop/web/components/buttons/icon-buttons Related: #4259 |
|
You should rebase, not merge everything in your branch. |
|
Just curious: Why did #4259 cause lag? How can I prevent this PR from causing lag? |
|
Because it had a dropdown menu and button on every row, that needed to be rendered/calculated, since this is just 1 icon on every row it should be ok. |
|
We can also just use this: https://github.com/feross/clipboard-copy/blob/master/index.js |
KTibow
force-pushed
the
clipboard-button
branch
2 times, most recently
from
1578b06 to
237391a
Compare
The clipboard fallback triggers if navigator.clipboard is falsey, or if an error occurs using navigator.clipboard. Thanks for helping improve the code Bram! Co-Authored-By: Bram Kragten <bramkragten@users.noreply.github.com>
KTibow
force-pushed
the
clipboard-button
branch
from
237391a to
8588f8f
Compare
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
5 participants
Moved to #8411
Proposed change
This adds a button next to the entity ID that copies the ID to the clipboard.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: