Skip to content

Improve user experience when enabling a disabled entity#7580

Merged
bramkragten merged 4 commits intohome-assistant:devfrom
emontnemery:entity_registry_extend_result
Nov 9, 2020
Merged

Improve user experience when enabling a disabled entity#7580
bramkragten merged 4 commits intohome-assistant:devfrom
emontnemery:entity_registry_extend_result

Conversation

@emontnemery
Copy link
Collaborator

Proposed change

Improve user experience when enabled a disabled entity:

  • Some entities won't be enabled until HA is restarted
  • Entities won't be enabled until after a long delay

Backend PR: home-assistant/core#42667

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@emontnemery
Copy link
Collaborator Author

emontnemery commented Nov 2, 2020

I've added popups in the three places where updateEntityRegistryEntry is called to enable disabled entities.

There are also calls from:

  • ha-config-device-page
    Only entity_id and name are modified here, so the check is not needed
  • ha-config-entities
    Popups added when enabling entitied, but not when they are disabled.
  • zha-device-card
    ZHA supports unload, so the check is not needed.

@bramkragten bramkragten merged commit 129f9c1 into home-assistant:dev Nov 9, 2020
KTibow pushed a commit to KTibow/frontend-1 that referenced this pull request Nov 10, 2020
KTibow added a commit to KTibow/frontend-1 that referenced this pull request Nov 10, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants