Skip to content

Add "www" to generated tag QR code#7577

Merged
bramkragten merged 2 commits intohome-assistant:devfrom
spacegaier:tag-qr-code-fix
Nov 7, 2020
Merged

Add "www" to generated tag QR code#7577
bramkragten merged 2 commits intohome-assistant:devfrom
spacegaier:tag-qr-code-fix

Conversation

@spacegaier
Copy link
Member

Breaking change

Proposed change

Fixes missing "www" in generated tag QR code.

Note: My writable NFC tags have not arrived yet, so I am not actually able to test that out in HA, but since this is a trivial PR, I guess that should be fine for this PR 😄.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@dshokouhi
Copy link
Member

We may want to tag this for a milestone hotfix since the mobile apps expect a certain format

Co-authored-by: Bram Kragten <mail@bramkragten.nl>
@bramkragten bramkragten merged commit a0e8d69 into home-assistant:dev Nov 7, 2020
KTibow pushed a commit to KTibow/frontend-1 that referenced this pull request Nov 7, 2020
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2020
@spacegaier spacegaier deleted the tag-qr-code-fix branch November 11, 2020 14:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

QR code generation does not match expected tag URL format for companion apps

4 participants