Skip to content

Calendar: Adds an Update Size and Makes list view start today and adds in local for first day of week#7541

Merged
zsarnett merged 6 commits intodevfrom
Calendar-Changes
Oct 30, 2020
Merged

Calendar: Adds an Update Size and Makes list view start today and adds in local for first day of week#7541
zsarnett merged 6 commits intodevfrom
Calendar-Changes

Conversation

@zsarnett
Copy link
Contributor

@zsarnett zsarnett commented Oct 30, 2020

Proposed change

This PR adds the ability to run updateSize on the Full Calendar Element. This method tells Full Calendar to rerun its sizing functions to fill the available width and height.

This also changes the list view we have from Week (Starting on the first day of the week and ending the last day of the week regardless of what the current day is) to just a list/agenda view that starts on the current day and spans 7 days in the future

Also, Adds in the locales from Full Calendar so that different starting days and translations work

Also, styles the Full Calendar Scroll bar

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

@zsarnett zsarnett changed the title Calendar: Adds an Update Size and Makes list view start today Calendar: Adds an Update Size and Makes list view start today and adds in local for first day of week Oct 30, 2020
@zsarnett
Copy link
Contributor Author

image

static get styles(): CSSResult[] {
return [
haStyle,
haStyleScrollbar,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this when we add the styles manually and removed the class?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you reviewed old code

@zsarnett zsarnett merged commit e555b24 into dev Oct 30, 2020
@zsarnett zsarnett deleted the Calendar-Changes branch October 30, 2020 22:03
@bramkragten bramkragten mentioned this pull request Nov 11, 2020
@zsarnett
Copy link
Contributor Author

Please do not comment on old PRs

@home-assistant home-assistant locked and limited conversation to collaborators Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Calendar list view should start today (or have the option of doing so)

3 participants