Skip to content

Mock subscribe template#7529

Merged
balloob merged 1 commit intodevfrom
fix-markdown-rendering-demo
Oct 29, 2020
Merged

Mock subscribe template#7529
balloob merged 1 commit intodevfrom
fix-markdown-rendering-demo

Conversation

@balloob
Copy link
Member

@balloob balloob commented Oct 29, 2020

Breaking change

Proposed change

Now that the markdown card uses subscribe template, we should also mock out that API so the markdown card works in the gallery.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@balloob balloob merged commit f1c16d6 into dev Oct 29, 2020
@balloob balloob deleted the fix-markdown-rendering-demo branch October 29, 2020 20:28
@bramkragten bramkragten mentioned this pull request Nov 11, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants