Skip to content

Fix glance card with header if parent does not set block#7526

Merged
bramkragten merged 1 commit intodevfrom
fix-glance-non-block-header
Oct 29, 2020
Merged

Fix glance card with header if parent does not set block#7526
bramkragten merged 1 commit intodevfrom
fix-glance-non-block-header

Conversation

@balloob
Copy link
Member

@balloob balloob commented Oct 29, 2020

Breaking change

Proposed change

The glance card with a header in a context that did not set display: block on the card was breaking the layout of the glance card. This was noticeable in the gallery.

Before:

image

After:

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link
Contributor

@zsarnett zsarnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not remove this. This will break in a stack, no? It should take the height of the tallest card in a horizontal stack

@bramkragten
Copy link
Member

We should not remove this. This will break in a stack, no? It should take the height of the tallest card in a horizontal stack

The card should, the entities not?

@zsarnett
Copy link
Contributor

Idk. Just want to make sure this doesn't break it

@balloob
Copy link
Member Author

balloob commented Oct 29, 2020

Then add it as a demo to the gallery! 😄

@bramkragten bramkragten added this to the 0.117.1 milestone Oct 29, 2020
@balloob
Copy link
Member Author

balloob commented Oct 29, 2020

No need to put it in the milestone. It's not broken in Lovelace itself, because we have .column > * { display: block; }

@bramkragten
Copy link
Member

bramkragten commented Oct 29, 2020

No need to put it in the milestone. It's not broken in Lovelace itself, because we have .column > * { display: block; }

Was thinking about stacks etc:

image

@bramkragten bramkragten merged commit 99935f1 into dev Oct 29, 2020
@bramkragten bramkragten deleted the fix-glance-non-block-header branch October 29, 2020 17:29
@balloob
Copy link
Member Author

balloob commented Oct 30, 2020

Ah yes. I thought it only impacted the gallery.

@bramkragten bramkragten mentioned this pull request Nov 11, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants