Fix glance card with header if parent does not set block#7526
Merged
bramkragten merged 1 commit intodevfrom Oct 29, 2020
Merged
Fix glance card with header if parent does not set block#7526bramkragten merged 1 commit intodevfrom
bramkragten merged 1 commit intodevfrom
Conversation
zsarnett
reviewed
Oct 29, 2020
Contributor
zsarnett
left a comment
There was a problem hiding this comment.
We should not remove this. This will break in a stack, no? It should take the height of the tallest card in a horizontal stack
Member
The card should, the entities not? |
Contributor
|
Idk. Just want to make sure this doesn't break it |
Member
Author
|
Then add it as a demo to the gallery! 😄 |
bramkragten
approved these changes
Oct 29, 2020
Member
Author
|
No need to put it in the milestone. It's not broken in Lovelace itself, because we have |
Member
Member
Author
|
Ah yes. I thought it only impacted the gallery. |
3 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Breaking change
Proposed change
The glance card with a header in a context that did not set
display: blockon the card was breaking the layout of the glance card. This was noticeable in the gallery.Before:
After:
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: