Skip to content

Convert ha-cover-controls to TypeScript/LitElement#7521

Merged
bramkragten merged 6 commits intohome-assistant:devfrom
iantrich:ts-cover-controls
Nov 12, 2020
Merged

Convert ha-cover-controls to TypeScript/LitElement#7521
bramkragten merged 6 commits intohome-assistant:devfrom
iantrich:ts-cover-controls

Conversation

@iantrich
Copy link
Member

@iantrich iantrich commented Oct 29, 2020

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@iantrich
Copy link
Member Author

Oh man...sorry guys. I meant to mark this as draft. Rushed it out before I started work this morning knowing it wasn't complete. Thanks for the reviews but sorry for wasting your time 😁

@zsarnett
Copy link
Contributor

Stop WASTING my time Ian 😠 😡 🤬

@iantrich
Copy link
Member Author

@zsarnett I take it back. I did this 100% on purpose to spite you Zack 😜

iantrich and others added 2 commits October 30, 2020 16:45
@bramkragten bramkragten merged commit 37a089c into home-assistant:dev Nov 12, 2020
@iantrich iantrich deleted the ts-cover-controls branch November 12, 2020 14:54
@bramkragten bramkragten mentioned this pull request Nov 26, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants