Skip to content

Use shopping list card in panel#7519

Merged
bramkragten merged 6 commits intohome-assistant:devfrom
iantrich:remove-shopping-panel
Nov 5, 2020
Merged

Use shopping list card in panel#7519
bramkragten merged 6 commits intohome-assistant:devfrom
iantrich:remove-shopping-panel

Conversation

@iantrich
Copy link
Member

Breaking change

Proposed change

Was looking at remaining Polymer code and thought it is probably time to retire the shopping list panel, especially with in the incoming enhancements to the card in #7296

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link
Contributor

@zsarnett zsarnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this require a backend change as well? I know for the Calendar Panel it setup in the back to show in the sidebar

@iantrich
Copy link
Member Author

@zsarnett I don't know that answer actually. Perhaps @bramkragten knows, otherwise I'll give a look sometime later

@zsarnett
Copy link
Contributor

@bramkragten
Copy link
Member

bramkragten commented Oct 29, 2020

So the idea is that a shopping-list card in panel mode would be the same? It would no longer be automatically setup though and thus is harder to find?

We could also make this panel use the card? Or are there other reasons to remove this panel?

@balloob
Copy link
Member

balloob commented Oct 29, 2020

I agree with Bram that this makes the shopping list impossible to find. This is not a good user experience. Since we can also disable panels now, I don't see a reason to drop the panel just because it's still Polymer.

@iantrich
Copy link
Member Author

iantrich commented Oct 29, 2020

The card being more feature rich than the panel was the motivation to drop it, I found by looking for remaining Polymer elements. I like the idea of using the card in the panel.

@balloob
Copy link
Member

balloob commented Oct 30, 2020

Just render the Shopping list panel as a Lovelace dashboard with 1 card 😆

@iantrich
Copy link
Member Author

iantrich commented Nov 1, 2020

image

So one this I forgot about is the microphone which gives the ability to add/delete via voice. Not sure how much that is used, but if we want that functionality back it should be put into the card IMO

@bramkragten bramkragten changed the title remove shopping-list panel Use shopping list card in panel Nov 1, 2020
@zsarnett
Copy link
Contributor

zsarnett commented Nov 1, 2020

I think we should just add the microphone to the panel like we do in Lovelace

@iantrich
Copy link
Member Author

iantrich commented Nov 2, 2020

I think we should just add the microphone to the panel like we do in Lovelace

for some reason I was thinking it was a shopping list specialized microphone thing, I never use it 😅. Yeah will add it.

? html`
<mwc-icon-button
.label=${this.hass!.localize(
"ui.panel.lovelace.menu.start_conversation"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't use translation tags from other panels, as they will not be available until that panel is loaded.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will that effect the translations for the shopping list card itself as it does use lovelace translations in it?

@bramkragten bramkragten merged commit 9a3a7c2 into home-assistant:dev Nov 5, 2020
@iantrich iantrich deleted the remove-shopping-panel branch November 5, 2020 18:42
@bramkragten bramkragten mentioned this pull request Nov 11, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants