Skip to content

Formats number state with selected language in compute_state_display #7516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bramkragten merged 5 commits into from
Oct 30, 2020
Merged

Formats number state with selected language in compute_state_display #7516

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6e1d8aa
Formats number state with selected language in compute_state_display
joshmcrty Oct 28, 2020
edaac16
Test for Intl support, break format func out into a separate file
joshmcrty Oct 29, 2020
1b7644f
Avoid comparing to self per eslint
joshmcrty Oct 29, 2020
1578af8
Don't use window global
joshmcrty Oct 29, 2020
e24e5d6
Add test for number formatting
joshmcrty Oct 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/common/entity/compute_state_display.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@ export const computeStateDisplay = (
}

if (stateObj.attributes.unit_of_measurement) {
if (!Number.isNaN(Number(compareState))) {
return `${new Intl.NumberFormat(language).format(Number(compareState))} ${
Comment thread
joshmcrty marked this conversation as resolved.
Outdated
stateObj.attributes.unit_of_measurement
}`;
}
return `${compareState} ${stateObj.attributes.unit_of_measurement}`;
}

Expand Down