Skip to content

Fix issue with toggles blocking dialog and dialog launching on mobile#7506

Merged
donkawechico merged 3 commits intodevfrom
quick-bar-fix-toggle-blocking-shortcuts
Oct 29, 2020
Merged

Fix issue with toggles blocking dialog and dialog launching on mobile#7506
donkawechico merged 3 commits intodevfrom
quick-bar-fix-toggle-blocking-shortcuts

Conversation

@donkawechico
Copy link
Contributor

@donkawechico donkawechico commented Oct 28, 2020

Proposed change

  1. Be more granular about which input fields should block dialog if focused. Fixes a bug where toggle buttons (which are inputs of type "checkbox") will block dialog launching if just clicked.
  2. Block dialog from launching on mobile devices (using detection code from http://detectmobilebrowsers.com/). Fixes an issue where iOS users currently in template / call service data field / automation editor fields will launch the dialog if they type e or c.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@donkawechico donkawechico modified the milestones: 0.117.0, 0.117.1 Oct 28, 2020
@donkawechico donkawechico force-pushed the quick-bar-fix-toggle-blocking-shortcuts branch 2 times, most recently from 6dcbba4 to e0e9e89 Compare October 29, 2020 05:00
@donkawechico donkawechico changed the title Fix issue with toggle buttons blocking quick bar shortcut Fix issue with toggles blocking dialog and dialog launching on mobile Oct 29, 2020
@donkawechico donkawechico force-pushed the quick-bar-fix-toggle-blocking-shortcuts branch 3 times, most recently from 06a15d4 to 5393895 Compare October 29, 2020 16:03
@donkawechico donkawechico force-pushed the quick-bar-fix-toggle-blocking-shortcuts branch from 5393895 to e0474e6 Compare October 29, 2020 16:04
@donkawechico donkawechico merged commit c7f5c6c into dev Oct 29, 2020
@delete-merged-branch delete-merged-branch bot deleted the quick-bar-fix-toggle-blocking-shortcuts branch October 29, 2020 16:18
bramkragten pushed a commit that referenced this pull request Oct 29, 2020
…#7506)

* Fix issue with some inputs blocking, or incorrectly allowing, keyboard shortcut activation

* Explicitly declare all input types that we can allow alphanumeric overrides

* Do not launch dialog in codemirror targets on mobile devices
@bramkragten bramkragten mentioned this pull request Nov 11, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Quickbar shortcuts "e" & "c" trigger the quickbar when typing in some text fields on a mobile device

3 participants