Fix issue with toggles blocking dialog and dialog launching on mobile#7506
Merged
donkawechico merged 3 commits intodevfrom Oct 29, 2020
Merged
Fix issue with toggles blocking dialog and dialog launching on mobile#7506donkawechico merged 3 commits intodevfrom
donkawechico merged 3 commits intodevfrom
Conversation
…d shortcut activation
bramkragten
reviewed
Oct 28, 2020
bramkragten
reviewed
Oct 28, 2020
6dcbba4 to
e0e9e89
Compare
bramkragten
reviewed
Oct 29, 2020
06a15d4 to
5393895
Compare
5393895 to
e0474e6
Compare
bramkragten
approved these changes
Oct 29, 2020
bramkragten
pushed a commit
that referenced
this pull request
Oct 29, 2020
…#7506) * Fix issue with some inputs blocking, or incorrectly allowing, keyboard shortcut activation * Explicitly declare all input types that we can allow alphanumeric overrides * Do not launch dialog in codemirror targets on mobile devices
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
eorc.Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: