Skip to content

Header/sidebar sizing#7470

Merged
bramkragten merged 13 commits intohome-assistant:devfrom
maykar:header-and-sidebar-sizing
Nov 11, 2020
Merged

Header/sidebar sizing#7470
bramkragten merged 13 commits intohome-assistant:devfrom
maykar:header-and-sidebar-sizing

Conversation

@maykar
Copy link
Contributor

@maykar maykar commented Oct 23, 2020

Proposed changes

  • Shrinks header height and sidebar width down to 56px from the current 64px
  • Makes all headers conform to --header-height
  • Fixes alignment of sidebar header text

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

New header height & sidebar width:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@maykar maykar changed the title Header and sidebar sizing Header/sidebar sizing and sidebar title Oct 23, 2020
@balloob
Copy link
Member

balloob commented Oct 24, 2020

Just a note that not every feature request needs to be implemented. We need to make sure that feature requests fit within our vision for what the frontend is, and what it is not.

@maykar maykar changed the title Header/sidebar sizing and sidebar title Header/sidebar sizing Oct 24, 2020
@Mariusthvdb
Copy link
Contributor

Mariusthvdb commented Oct 24, 2020

where can we discuss that Paulus?
as it is, I can feel for the branding issue, hope you also see the user need for essential feedback on the system.

Wouldn't you agree the Frontend mainly is for returning that essential feedback to the user, and much less so a branding vehicle

Especially so, since with the default (and not optionable) new compact header, the user is taken a spot where this resided before unfortunately.

@balloob
Copy link
Member

balloob commented Oct 24, 2020

Not interested in discussing that. Either use the custom JS that Maykar made or add a markdown card with the title.

@bramkragten
Copy link
Member

The header of hass-loading-screen is not adjusted yet

@bramkragten bramkragten merged commit 216fce7 into home-assistant:dev Nov 11, 2020
@bramkragten bramkragten mentioned this pull request Nov 11, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants