Skip to content

Replace prompt with showPromptDialog#7460

Merged
bramkragten merged 5 commits intohome-assistant:devfrom
TheZoker:replace-prompt
Oct 27, 2020
Merged

Replace prompt with showPromptDialog#7460
bramkragten merged 5 commits intohome-assistant:devfrom
TheZoker:replace-prompt

Conversation

@TheZoker
Copy link
Contributor

@TheZoker TheZoker commented Oct 22, 2020

Breaking change

None

Proposed change

Replace the outdated prompt() function for the notification device name dialog with a material dialog.

Screenshot_2020 10 23_01h36m23s_010_

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

TheZoker and others added 2 commits October 23, 2020 16:40
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
@TheZoker TheZoker requested a review from bramkragten October 23, 2020 14:45
@bramkragten bramkragten merged commit ba4c2fc into home-assistant:dev Oct 27, 2020
@bramkragten bramkragten mentioned this pull request Nov 11, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Push notification name still uses browser prompt()

4 participants