Skip to content

Migrate ha-paper-dialog to ha-dialog in system options dialog#7455

Merged
bramkragten merged 4 commits intohome-assistant:devfrom
joshmcrty:dev
Oct 27, 2020
Merged

Migrate ha-paper-dialog to ha-dialog in system options dialog#7455
bramkragten merged 4 commits intohome-assistant:devfrom
joshmcrty:dev

Conversation

@joshmcrty
Copy link
Contributor

Proposed change

This replaces the use of ha-paper-dialog with ha-dialog for the System Options dialog on the Integrations page. It also adds a public closeDialogmethod per #6138

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Add an integration via the UI, then on the Integrations page, click the three dots menu for the integration and select "System options" to view the new dialog.

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@joshmcrty joshmcrty requested a review from bramkragten October 27, 2020 04:33
@bramkragten bramkragten merged commit a19477d into home-assistant:dev Oct 27, 2020
@bramkragten bramkragten mentioned this pull request Nov 11, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants