Skip to content

Problem device class #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 2 commits into from
Dec 14, 2017
Merged

Problem device class #726

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1319072
Problem device class
emlove Dec 12, 2017
3aa23a4
Move OK/Problem master to binary_sensor
emlove Dec 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/translations/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,10 @@
"off": "[%key:state::device_tracker::not_home%]",
"on": "[%key:state::device_tracker::home%]"
},
"problem": {
"off": "[%key:state::plant::ok%]",

@balloob balloob Dec 12, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be under binary_sensor ?

@emlove emlove Dec 12, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, plant became the master since this didn't exist at the time, but this would have been the master otherwise. I'll reorganize it.

"on": "[%key:state::plant::problem%]"
},
"safety": {
"off": "Safe",
"on": "Unsafe"
Expand Down
1 change: 1 addition & 0 deletions src/util/hass-util.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,7 @@
return activated ? 'mdi:crop-portrait' : 'mdi:vibrate';
case 'gas':
case 'power':
case 'problem':
case 'safety':
case 'smoke':
return activated ? 'mdi:verified' : 'mdi:alert';
Expand Down