More-Info Dialog Logbook Bug Fix#7152
Merged
bramkragten merged 2 commits intohome-assistant:devfrom Sep 29, 2020
Merged
Conversation
On smaller devices, the more-info dialog is rendered fullscreen. Optimizations for such devices were required.
bramkragten
reviewed
Sep 28, 2020
| } | ||
| @media all and (max-width: 450px), all and (max-height: 500px) { | ||
| ha-logbook { | ||
| max-height: calc(100vh - 230px); |
Member
There was a problem hiding this comment.
The 230px will only work for a timeline graph, if you have any other type of graph, or no history at all it will not work correctly.
You should work with a flex box to fix that.
Contributor
Author
There was a problem hiding this comment.
@bramkragten Thank you, didn't play out that scenario. Will look into this further!
Contributor
Author
There was a problem hiding this comment.
@bramkragten The max-height is now unset on smaller screens. I believe this may provide the optimal scrolling experience on mobile. Please let me know if you disagree and prefer the flex layout.
Thanks for taking the time!
bramkragten
approved these changes
Sep 29, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On smaller devices, the more-info dialog is rendered fullscreen. Optimizations for such devices were required.
Proposed change
Add a new @media query adding more-info logbook support for smaller devices by replacing the CSS max-height on the "ha-logbook" class with a CSS calculation. Appreciate any feedback!
Before
After
Type of change
Checklist