Skip to content

Prevent deletion of the owner user#7116

Merged
bramkragten merged 1 commit intodevfrom
prevent-admin-deletion
Sep 24, 2020
Merged

Prevent deletion of the owner user#7116
bramkragten merged 1 commit intodevfrom
prevent-admin-deletion

Conversation

@ludeeus
Copy link
Member

@ludeeus ludeeus commented Sep 23, 2020

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@penright
Copy link

To add a thought. Most of the time that the "owner" user was deleted, was because they forgot the password. There needs to be a way to recover the password for the owner. Also, what happens if a person is already in the "owner-less" situation. It may not be worth the trouble either way, just wanted to throw those thoughts out there.

@ludeeus
Copy link
Member Author

ludeeus commented Sep 23, 2020

While I do agree, that is out of the scope of this PR.
Feel free to open a Feature Request

@KTibow
Copy link
Contributor

KTibow commented Sep 23, 2020

Wouldn't a warning be better?

@ludeeus
Copy link
Member Author

ludeeus commented Sep 23, 2020

Not really, you should not delete the owner account, if you lost its password and that is the reason you are deleting it (like the docs tell you to do), there is a CLI tool for that.
Other than that I see no reason why deleting the owner should be possible.

@bramkragten bramkragten merged commit bbee94e into dev Sep 24, 2020
@bramkragten bramkragten deleted the prevent-admin-deletion branch September 24, 2020 11:45
@bramkragten bramkragten mentioned this pull request Sep 30, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants