Skip to content

Merge ha-paper-slider into ha-slider#7114

Merged
bramkragten merged 1 commit intodevfrom
merge-sliders
Sep 24, 2020
Merged

Merge ha-paper-slider into ha-slider#7114
bramkragten merged 1 commit intodevfrom
merge-sliders

Conversation

@thomasloven
Copy link
Contributor

Proposed change

Merge ha-paper-slider (which modifies some styles of paper-slider) into ha-slider (which fixes a rounding problem with paper-slider).

I don't understand why there were two of them anyway.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten
Copy link
Member

This could be breaking for custom card developers

@bramkragten bramkragten merged commit b2e2dbe into dev Sep 24, 2020
@bramkragten bramkragten deleted the merge-sliders branch September 24, 2020 12:16
@bramkragten bramkragten added the Breaking Change Needs Special Documentation to let users know about Change label Sep 24, 2020
@thomasloven
Copy link
Contributor Author

ha-paper-slider is already "broken" by lazy-loading more-info dialogs.
Of the two sliders ha-paper-slider looked better but was lazy-loaded since 0.115, and ha-slider behaved better and was not lazy-loaded.
The new ha-slider is (currently) immediately loaded and now has the good looks of ha-paper-slider.

@bramkragten
Copy link
Member

What is loading ha-slider?

@thomasloven
Copy link
Contributor Author

The more-info controls for light entities. Through ha-labeled-slider.

@bramkragten
Copy link
Member

bramkragten commented Sep 28, 2020

But the more info controls are(were) lazy loaded?

@thomasloven
Copy link
Contributor Author

thomasloven commented Sep 28, 2020

You're right. I assumed some were notalways (bad typo) loaded, and that's why it worked.
But I found it:

import "../../state-summary/state-card-content";

import "./state-card-input_number";

import "../components/ha-slider";

... which probably should be lazy loaded too...

@bramkragten
Copy link
Member

bramkragten commented Sep 28, 2020

I wonder if we should replace the state-card-content with the Lovelace entity row

@bramkragten bramkragten mentioned this pull request Sep 30, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Breaking Change Needs Special Documentation to let users know about Change cla-signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants