Skip to content

fix media icon diff#7071

Merged
bramkragten merged 2 commits intodevfrom
media-icon-fix
Sep 21, 2020
Merged

fix media icon diff#7071
bramkragten merged 2 commits intodevfrom
media-icon-fix

Conversation

@zsarnett
Copy link
Contributor

Breaking change

Proposed change

image
image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@zsarnett zsarnett added this to the 0.115.2 milestone Sep 19, 2020
@zsarnett
Copy link
Contributor Author

Relying on VScode to tell me something isn't imported really bites you sometimes

@bramkragten
Copy link
Member

Relying on VScode to tell me something isn't imported really bites you sometimes

Well it was imported, but through another component, it will be a problem when that element is removed...

@bramkragten bramkragten merged commit 0fb3814 into dev Sep 21, 2020
@bramkragten bramkragten deleted the media-icon-fix branch September 21, 2020 15:44
@bramkragten bramkragten mentioned this pull request Sep 30, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants